Probably unpopular opinion, but peer reviews are overrated. If coders are good AND know the project, the only thing you can do in a PR is nitpicking. They are more useful for open source collaborators because you want to double-check their code fits with the current architecture. But people here are reacting as if peer reviews could actually spot bugs that tests can’t catch. That happens rarely unless the contributor is junion/not good.
- 0 Posts
- 4 Comments
Joined 1 year ago
Cake day: July 10th, 2023
You are not logged in. If you use a Fediverse account that is able to follow users, you can follow this user.
I would fire you for incompetence and sabotage. Problem solved.
Follow up of: “Mmm… should I put lifecycle annotation in these 10 structs or just use and Rc and call it a day?”. Rc and Box FTW.
Code review can’t fix incompence though. I lost count of how many times my boss told me “review that PR well because X is not very good”. Also my point is that they are overrated, not that they are useless.